Add Text: a string abstraction to replace vanilla string objects#170
Draft
achieveordie wants to merge 2 commits intopython-visualization:mainfrom
Draft
Add Text: a string abstraction to replace vanilla string objects#170achieveordie wants to merge 2 commits intopython-visualization:mainfrom
Text: a string abstraction to replace vanilla string objects#170achieveordie wants to merge 2 commits intopython-visualization:mainfrom
Conversation
Contributor
Author
|
FYI @hansthen |
Contributor
Author
|
The implementation is not yet complete/correct but at this point, I'm only hoping to discuss the design decisions I've made and whether any of it doesn't fit well with the imagined use-case. |
Contributor
Author
|
Here's a quick script (specifically made for backslashes) and the results: from branca.text import Text
def scenario_1():
string = r"<div>\\file\2019</div>"
text = Text(text_str=string)
print("Scenario_1: ", text)
def scenario_2():
string = r"<div>\\file\2019</div>"
text = Text(text_str=string, parse=False)
print("Scenario_2: ", text)
def scenario_3():
string = r"<div>\\\\file\\2019</div>"
text = Text(text_str=string, parse=True)
print("Scenario_3: ", text)
def scenario_4():
string = r"<div>\\\\file\\2019</div>"
text = Text(text_str=string, parse=False)
print("Scenario_4: ", text)
if __name__ == "__main__":
scenario_1()
print("==" * 25)
scenario_2()
print("==" * 25)
scenario_3()
print("==" * 25)
scenario_4()
print("==" * 25)Output: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial discussion present in: python-visualization/folium#1907
The
Textclass will be used wherever plain strings are used (popup labels, tooltip text etc).Currently, the only feature is to enable escaping characters (specifically: backticks, backslashes and double quotes). I chose these three for the time being since I saw them being used in some capacity in the codebase.
This PR is incomplete (need to add magic dunders, more examples, extension template to other operations, test cases etc) but I wanted to open a draft PR so we can begin our discussion without much ado.